feat(KNO-9339): enable use of branches with SlackKit #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b044d8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mattmikolay
changed the title
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
This reverts commit d6d83ca.
mattmikolay
force-pushed
the
mattmik-kno-9339-slackkit-include-branch-slug-in-encoded-state-param
branch
from
bec2f41 to
b044d8c
Compare
kylemcd
approved these changes
Aug 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mattmik-kno-9338-javascript-sdks-add-support-for-x-knock-branch-header-to-js #703 +/- ##
================================================================================================================
+ Coverage 63.34% 63.35% +0.01%
================================================================================================================
Files 181 181
Lines 7221 7223 +2
Branches 853 853
================================================================================================================
+ Hits 4574 4576 +2
Misses 2621 2621
Partials 26 26
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the use of branches with SlackKit by updating the
useSlackAuthhook to include abranch_slugin the encodedstateparam.Checklist
Screenshots or videos
Loom demo